RE: [Patch v13 0/4] This patchset is to remove PPCisms for QEIC

[Qiang Zhao]

Hi Thomas and Marc,

Is there any feedback? Thank you!

Best Regards
Qiang Zhao

> -----Original Message-----
> From: Zhao Qiang [mailto:qiang.zhao@xxxxxxx]
> Sent: Friday, November 10, 2017 11:31 AM
> To: tglx@xxxxxxxxxxxxx; marc.zyngier@xxxxxxx; jason@xxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Qiang Zhao <qiang.zhao@xxxxxxx>
> Subject: [Patch v13 0/4] This patchset is to remove PPCisms for QEIC
> 
> QEIC is an interrupt controller for QE, was put under drivers/soc/fsl/qe, and now
> move to driver/irqchip.
> And QEIC is supported more than just powerpc boards, so remove PPCisms.
> 
> changelog:
> 	Changes for v8:
> 	- use IRQCHIP_DECLARE() instead of subsys_initcall in qeic driver
> 	- remove include/soc/fsl/qe/qe_ic.h
> 	Changes for v9:
> 	- rebase
> 	- fix the compile issue when apply the second patch, in fact, there was
> no compile issue
> 	  when apply all the patches of this patchset
> 	Changes for v10:
> 	- simplify codes, remove duplicated codes
> 	Changes for v11:
> 	- rebase
> 	Changes for v13:
> 	- rewrite single-bit constants to BIT(x) to make the code more readable
> 
> Zhao Qiang (4):
>   irqchip/qeic: move qeic driver from drivers/soc/fsl/qe
> 	Changes for v2:
> 		- modify the subject and commit msg
> 	Changes for v3:
> 		- merge .h file to .c, rename it with irq-qeic.c
> 	Changes for v4:
> 		- modify comments
> 	Changes for v5:
> 		- disable rename detection
> 	Changes for v6:
> 		- rebase
> 	Changes for v7:
> 		- na
> 
>   irqchip/qeic: merge qeic init code from platforms to a common function
> 	Changes for v2:
> 		- modify subject and commit msg
> 		- add check for qeic by type
> 	Changes for v3:
> 		- na
> 	Changes for v4:
> 		- na
> 	Changes for v5:
> 		- na
> 	Changes for v6:
> 		- rebase
> 	Changes for v7:
> 		- na
> 	Changes for v8:
> 		- use IRQCHIP_DECLARE() instead of subsys_initcall
> 
>   irqchip/qeic: merge qeic_of_init into qe_ic_init
> 	Changes for v2:
> 		- modify subject and commit msg
> 		- return 0 and add put node when return in qe_ic_init
> 	Changes for v3:
> 		- na
> 	Changes for v4:
> 		- na
> 	Changes for v5:
> 		- na
> 	Changes for v6:
> 		- rebase
> 	Changes for v7:
> 		- na
> 	Changes for v12:
> 		- remove unused code
> 
>   irqchip/qeic: remove PPCisms for QEIC
> 	Changes for v6:
> 		- new added
> 	Changes for v7:
> 		- fix warning
> 	Changes for v8:
> 		- remove include/soc/fsl/qe/qe_ic.h
> 
> Zhao Qiang (4):
>   irqchip/qeic: move qeic driver from drivers/soc/fsl/qe
>   irqchip/qeic: merge qeic init code from platforms to a common function
>   irqchip/qeic: merge qeic_of_init into qe_ic_init
>   irqchip/qeic: remove PPCisms for QEIC
> 
>  MAINTAINERS                                        |   6 +
>  arch/powerpc/platforms/83xx/km83xx.c               |   1 -
>  arch/powerpc/platforms/83xx/misc.c                 |  16 -
>  arch/powerpc/platforms/83xx/mpc832x_mds.c          |   1 -
>  arch/powerpc/platforms/83xx/mpc832x_rdb.c          |   1 -
>  arch/powerpc/platforms/83xx/mpc836x_mds.c          |   1 -
>  arch/powerpc/platforms/83xx/mpc836x_rdk.c          |   1 -
>  arch/powerpc/platforms/85xx/corenet_generic.c      |  10 -
>  arch/powerpc/platforms/85xx/mpc85xx_mds.c          |  15 -
>  arch/powerpc/platforms/85xx/mpc85xx_rdb.c          |  17 -
>  arch/powerpc/platforms/85xx/twr_p102x.c            |  15 -
>  drivers/irqchip/Makefile                           |   1 +
>  drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} | 423 +++++++++++----------
>  drivers/soc/fsl/qe/Makefile                        |   2 +-
>  drivers/soc/fsl/qe/qe_ic.h                         | 103 -----
>  include/soc/fsl/qe/qe_ic.h                         | 139 -------
>  16 files changed, 231 insertions(+), 521 deletions(-)  rename
> drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} (53%)  delete mode 100644
> drivers/soc/fsl/qe/qe_ic.h  delete mode 100644 include/soc/fsl/qe/qe_ic.h
> 
> --
> 2.14.1