Re: [PATCH v3 4/9] KVM: x86: Add Intel Processor Trace cpuid emulation

[Paolo Bonzini]

On 27/11/2017 21:23, Luwei Kang wrote:
> +		int t, times = entry->eax & 0xffffffff;

This AND is not necessary.

Paolo

> +
> +		if (!f_intel_pt)
> +			break;
> +
> +		entry->flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
> +		for (t = 1; t <= times; ++t) {
> +			if (*nent >= maxnent)
> +				goto out;
> +			do_cpuid_1_ent(&entry[t], function, t);
> +			entry[t].flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
> +			++*nent;
> +		}
> +		break;
> +	}