Re: [PATCH v1] USB: storage: Remove obsolete "FIXME"

[Alan Stern]

On Thu, 30 Nov 2017, Mikhail Zaytsev wrote:

> The fix of "FIXME: Notify the subdrivers..." doesn't actually have any
>  real effect. The "FIXME" changed to simple comment. 
> 
> Signed-off-by: Mikhail Zaytsev <flashed@xxxxxxx>
> ---
>  drivers/usb/storage/usb.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
> index a0c07e0..3eb9347 100644
> --- a/drivers/usb/storage/usb.c
> +++ b/drivers/usb/storage/usb.c
> @@ -211,8 +211,8 @@ int usb_stor_reset_resume(struct usb_interface *iface)
>  	usb_stor_report_bus_reset(us);
>  
>  	/*
> -	 * FIXME: Notify the subdrivers that they need to reinitialize
> -	 * the device
> +	 * If any of the subdrivers implemented a reinitialization scheme,
> +	 * this is where the callback would be invoked.
>  	 */
>  	return 0;
>  }
> @@ -243,8 +243,8 @@ int usb_stor_post_reset(struct usb_interface *iface)
>  	usb_stor_report_bus_reset(us);
>  
>  	/*
> -	 * FIXME: Notify the subdrivers that they need to reinitialize
> -	 * the device
> +	 * If any of the subdrivers implemented a reinitialization scheme,
> +	 * this is where the callback would be invoked.
>  	 */
>  
>  	mutex_unlock(&us->dev_mutex);

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>