Re: [PATCH v3 3/3] virt: Add vboxguest driver for Virtual Box Guest integration

[Hans de Goede]

Hi,

On 29-11-17 18:10, Philippe Ombredanne wrote:
> On Wed, Nov 29, 2017 at 4:55 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> > diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
> > new file mode 100644
> > index 000000000000..631101578c2a
> > --- /dev/null
> > +++ b/drivers/virt/vboxguest/vboxguest_core.c
> > @@ -0,0 +1,1582 @@
> > +/*
> > + * vboxguest core guest-device handling code, VBoxGuest.cpp in upstream svn.
> > + *
> > + * Copyright (C) 2007-2016 Oracle Corporation
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
> > + * The contents of this file may alternatively be used under the terms
> > + * of the Common Development and Distribution License Version 1.0
> > + * (CDDL) only, in which case the provisions of the CDDL are applicable
> > + * instead of those of the GPL.
> > + *
> > + * You may elect to license modified versions of this file under the
> > + * terms and conditions of either the GPL or the CDDL or both.
> > + */
>
> Hans:
> Could it make sense to replace this whole license boilerplate with the
> new SPDX license ids? e.g. use this instead:
>
> > +// SPDX-License-Identifier: (GPL-2.0 OR CDDL-1.0)
> > +/*
> > + * vboxguest core guest-device handling code, VBoxGuest.cpp in upstream svn.
> > + *
> > + * Copyright (C) 2007-2016 Oracle Corporation
>
> This would me much more compact and has the same effect. IMHO this
> especially makes sense for new code as we are still cleaning the rest
> of the kernel, so this would avoid extra work to clean this up later.

Yes that is a good idea, thank you.

I've made that change locally and I will post a v4 with this change
right after this mail.

Regards,

Hans