Re: [RFC PATCH] KVM: x86: Allow Qemu/KVM to use PVH entry point

From: Maran Wilson
Date: Thu Nov 30 2017 - 13:23:49 EST


On 11/29/2017 6:44 AM, Paolo Bonzini wrote:
I actually like this patch, except that I'd get the e820 memory map from
fw_cfg (see the first part of
https://github.com/bonzini/qboot/blob/master/fw_cfg.c, and extract_e820
inhttps://github.com/bonzini/qboot/blob/master/main.c) instead of the
second module.

Hi Paolo,

I want to make sure I understand exactly what you are suggesting...

Are you saying the Linux PVH entry code (such as init_pvh_bootparams()) should use the fw_cfg interface to read the e820 memory map data and put it into the zeropage? Basically, keeping the patch very much like it already is, just extracting the e820 data via the fw_cfg interface instead of from the second module of start_info struct?

If that is the case, I guess I'm a bit hesitant to throw the QEMU specific fw_cfg interface into the mix on the Linux PVH side when the existing PVH ABI already seems to contain an interface for passing modules/blobs to the guest. But if you feel there is a compelling reason to use the fw_cfg interface here, I'm happy to explore that approach further.

Thanks,
-Maran