Re: [PATCH net-next 2/3] xfrm: Fix xfrm_dev_state_add to fail for unsupported HW SA option

[Steffen Klassert]

On Tue, Nov 28, 2017 at 11:49:29AM +0200, yossefe@xxxxxxxxxxxx wrote:
> From: Yossef Efraim <yossefe@xxxxxxxxxxxx>
> 
> xfrm_dev_state_add function returns success for unsupported HW SA options.
> Resulting the calling function to create SW SA without corrlating HW SA.
> Desipte IPSec device offloading option was chosen.
> These not supported HW SA options are hard coded within xfrm_dev_state_add
> function.
> SW backward compatibility will break if we add any of these option as old
> HW will fail with new SW.
> 
> This patch changes the behaviour to return -EINVAL in case unsupported
> option is chosen.
> Notifying user application regarding failure and not breaking backward
> compatibility for newly added HW SA options.
> 
> Signed-off-by: Yossef Efraim <yossefe@xxxxxxxxxxxx>

Also applied to ipsec-next, thanks a lot!