RE: [PATCH 2/2] mtd: m25p80: restore the addressing mode when stop using the flash

[Z.q. Hou]

Hi Cyrille,

Thanks for your comments!

> -----Original Message-----
> From: Cyrille Pitchen [mailto:cyrille.pitchen@xxxxxxxxxx]
> Sent: 2017å12æ1æ 16:58
> To: Z.q. Hou <zhiqiang.hou@xxxxxxx>; linux-mtd@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; computersforpeace@xxxxxxxxx;
> dwmw2@xxxxxxxxxxxxx; boris.brezillon@xxxxxxxxxxxxxxxxxx;
> marek.vasut@xxxxxxxxx; richard@xxxxxx
> Subject: Re: [PATCH 2/2] mtd: m25p80: restore the addressing mode when
> stop using the flash
> 
> Hi Hou,
> 
> Le 24/11/2017 Ã 11:08, Zhiqiang Hou a ÃcritÂ:
> > From: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>
> >
> > Add .shutdown function to restore the addressing mode in reboot
> > process, and add the same operation to the .remove function.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>
> > ---
> >  drivers/mtd/devices/m25p80.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/mtd/devices/m25p80.c
> > b/drivers/mtd/devices/m25p80.c index dbe6a1de2bb8..867bd2d5a267
> 100644
> > --- a/drivers/mtd/devices/m25p80.c
> > +++ b/drivers/mtd/devices/m25p80.c
> > @@ -307,10 +307,17 @@ static int m25p_remove(struct spi_device *spi)
> > {
> >  	struct m25p	*flash = spi_get_drvdata(spi);
> >
> > +	spi_nor_restore_addr_mode(&flash->spi_nor);
> 
> maybe add a new line here.
> 
> Otherwise, this looks good :)

Yes, will add in next version, thanks a lot for the suggestion!


Thanks,
Zhiqiang