Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

From: Mark Brown
Date: Fri Dec 01 2017 - 07:49:54 EST


On Fri, Dec 01, 2017 at 10:13:27AM +0100, Philippe Ombredanne wrote:
> On Fri, Dec 1, 2017 at 9:58 AM, Erick Chen <erick.chen@xxxxxxxxxxxxxx> wrote:

> I think that per Linus, and Thomas doc patches for SPDX ids this
> should be instead either:

> > +// SPDX-License-Identifier: GPL-2.0
> > + // Copyright (c) 2017 Spreadtrum Communications Inc.

> or at least this with the id on the first and the // comment style

> > +// SPDX-License-Identifier: GPL-2.0

Are you saying SPDX requires C++ style comments? That seems totally
broken.

Attachment: signature.asc
Description: PGP signature