Re: [PATCH RFC 2/6] x86/hyper-v: add a function to read both TSC and TSC page value simulateneously

From: Stephen Hemminger
Date: Fri Dec 01 2017 - 12:29:23 EST


On Fri, 1 Dec 2017 14:13:17 +0100
Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> wrote:

> +
> +static inline u64 hv_read_tsc_page_tsc(const struct ms_hyperv_tsc_page *tsc_pg,
> + u64 *cur_tsc)
> +{
> + *cur_tsc = rdtsc();
> +
> + return cur_tsc;

Why do return and setting by reference. Looks like an ugly API.