Re: [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager.

[David Daney]

On 11/30/2017 11:53 PM, Philippe Ombredanne wrote:
> Carlos,
>
> On Thu, Nov 30, 2017 at 11:53 PM, James Hogan <james.hogan@xxxxxxxx> wrote:
> > On Tue, Nov 28, 2017 at 04:55:35PM -0800, David Daney wrote:
> > > From: Carlos Munoz <cmunoz@xxxxxxxxxx>
> > >
> > > Add a global resource manager to manage tagged pointers within
> > > bootmem allocated memory. This is used by various functional
> > > blocks in the Octeon core like the FPA, Ethernet nexus, etc.
> > >
> > > Signed-off-by: Carlos Munoz <cmunoz@xxxxxxxxxx>
> > > Signed-off-by: Steven J. Hill <Steven.Hill@xxxxxxxxxx>
> > > Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
> > > ---
> > >   arch/mips/cavium-octeon/Makefile       |   3 +-
> > >   arch/mips/cavium-octeon/resource-mgr.c | 371 +++++++++++++++++++++++++++++++++
> > >   arch/mips/include/asm/octeon/octeon.h  |  18 ++
> > >   3 files changed, 391 insertions(+), 1 deletion(-)
> > >   create mode 100644 arch/mips/cavium-octeon/resource-mgr.c
> > >
> > > diff --git a/arch/mips/cavium-octeon/Makefile b/arch/mips/cavium-octeon/Makefile
> > > index 7c02e542959a..0a299ab8719f 100644
> > > --- a/arch/mips/cavium-octeon/Makefile
> > > +++ b/arch/mips/cavium-octeon/Makefile
> > > @@ -9,7 +9,8 @@
> > >   # Copyright (C) 2005-2009 Cavium Networks
> > >   #
> > >
> > > -obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o
> > > +obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o \
> > > +      resource-mgr.o
> >
> > Maybe put that on a separate line like below.
> >
> > >   obj-y += dma-octeon.o
> > >   obj-y += octeon-memcpy.o
> > >   obj-y += executive/
> > > diff --git a/arch/mips/cavium-octeon/resource-mgr.c b/arch/mips/cavium-octeon/resource-mgr.c
> > > new file mode 100644
> > > index 000000000000..ca25fa953402
> > > --- /dev/null
> > > +++ b/arch/mips/cavium-octeon/resource-mgr.c
> > > @@ -0,0 +1,371 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Resource manager for Octeon.
> > > + *
> > > + * This file is subject to the terms and conditions of the GNU General Public
> > > + * License.  See the file "COPYING" in the main directory of this archive
> > > + * for more details.
> > > + *
> > > + * Copyright (C) 2017 Cavium, Inc.
> > > + */
>
> Since you nicely included an SPDX id, you would not need the
> boilerplate anymore. e.g. these can go alright?

They may not be strictly speaking necessary, but I don't think they hurt 
anything.  Unless there is a requirement to strip out the license text, 
we would stick with it as is.

> > > + * This file is subject to the terms and conditions of the GNU General Public
> > > + * License.  See the file "COPYING" in the main directory of this archive
> > > + * for more details.