Re: [PATCH tip/core/rcu 2/6] srcu: Change printk() %p to %pK

From: Lai Jiangshan
Date: Fri Dec 01 2017 - 20:27:54 EST


On Sat, Dec 2, 2017 at 3:41 AM, Paul E. McKenney
<paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> This commit changes the %p printk() in rcutorture to %pK. This could
> be considered irrelevant, given that any user able to start rcutorture
> could inflict far heavier damage on the system, but it doesn't hurt to
> change it and doing so avoids script-generated noise.
>
> Reported-by: Tobin C. Harding <me@xxxxxxxx>
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Lai Jiangshan <jiangshanlai@xxxxxxxxx>

> ---
> kernel/rcu/srcutree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> index d5cea81378cc..81f2eb78c504 100644
> --- a/kernel/rcu/srcutree.c
> +++ b/kernel/rcu/srcutree.c
> @@ -386,7 +386,7 @@ void cleanup_srcu_struct(struct srcu_struct *sp)
> flush_delayed_work(&per_cpu_ptr(sp->sda, cpu)->work);
> if (WARN_ON(rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)) != SRCU_STATE_IDLE) ||
> WARN_ON(srcu_readers_active(sp))) {
> - pr_info("cleanup_srcu_struct: Active srcu_struct %p state: %d\n", sp, rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)));
> + pr_info("cleanup_srcu_struct: Active srcu_struct %pK state: %d\n", sp, rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)));
> return; /* Caller forgot to stop doing call_srcu()? */
> }
> free_percpu(sp->sda);
> --
> 2.5.2
>