Re: [PATCH] iio: dummy_evgen: modify the return value check for irq_sim_init()

[Jonathan Cameron]

On Mon, 27 Nov 2017 11:54:49 +0100
Bartosz Golaszewski <brgl@xxxxxxxx> wrote:

> As discussed with Marc Zyngier: irq_sim_init() and its devres variant
> should return the base of the allocated interrupt range on success
> rather than 0. This will be modified later - first, change the way
> users handle the return value of these routines.
> 
> Signed-off-by: Bartosz Golaszewski <brgl@xxxxxxxx>
I'm happy to take this but if it goes via my tree whilst the
other changes take a different path you are going to slow things
down considerably (a kernel cycle for this change to be in the
upstream of where the fix gets applied).  So I would bundle
it up in a single patch set with the more major changes.

If you still want me to take it let me know, but if it
might go via another route then

Acked-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>

Thanks,

Jonathan
> ---
>  drivers/iio/dummy/iio_dummy_evgen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c
> index fe8884543da0..efd0005f59b4 100644
> --- a/drivers/iio/dummy/iio_dummy_evgen.c
> +++ b/drivers/iio/dummy/iio_dummy_evgen.c
> @@ -56,7 +56,7 @@ static int iio_dummy_evgen_create(void)
>  		return -ENOMEM;
>  
>  	ret = irq_sim_init(&iio_evgen->irq_sim, IIO_EVENTGEN_NO);
> -	if (ret) {
> +	if (ret < 0) {
>  		kfree(iio_evgen);
>  		return ret;
>  	}