Re: [PATCH] gpio: gpio-stmpe: make various char arrays static const, shrinks object size

From: Linus Walleij
Date: Sat Dec 02 2017 - 07:06:05 EST


On Tue, Nov 28, 2017 at 7:23 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate the read-only arrays edge_det_values, rise_values and
> fall_values on the stack but instead make them static and constify them.
> Makes the object code smaller by over 240 bytes:
>
> Before:
> text data bss dec hex filename
> 9525 2520 192 12237 2fcd drivers/gpio/gpio-stmpe.o
>
> After:
> text data bss dec hex filename
> 9025 2776 192 11993 2ed9 drivers/gpio/gpio-stmpe.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Patch applied.

Yours,
Linus Walleij