Re: [PATCH] staging: pi433: Bugfix for shift operation in rf69_get_modulation()

From: Greg KH
Date: Sat Dec 02 2017 - 10:45:09 EST


On Sat, Dec 02, 2017 at 12:32:20PM +0200, Marcus Wolf wrote:
> Defines used in cases contain already shifted bits, so currentValue must not be shifted.

Please properly wrap your changelog text.

And you need a blank line before your signed-off-by line.

> signed_of_by: Marcus Wolf <linux@xxxxxxxxxxxxxxxxxxxxx>

"Signed-off-by:"

Did you run scripts/checkpatch.pl on your patch?

You sent 4 patches just now, which order should I apply them in? I have
no idea, so please fix them up and resend them as a numbered patch
series so that I have a chance to get it right.

thanks,

greg k-h