Re: [PATCH v2] NTB: ntb_perf: Add full multi-port NTB API support

From: kbuild test robot
Date: Sun Dec 03 2017 - 12:59:07 EST

Hi Serge,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v4.15-rc1]
[cannot apply to ntb/ntb-next next-20171201]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Serge-Semin/NTB-ntb_perf-Add-full-multi-port-NTB-API-support/20171204-011126
config: parisc-allmodconfig (attached as .config)
compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=parisc

All warnings (new ones prefixed by >>):

drivers/ntb//test/ntb_perf.c: In function 'perf_msg_cmd_send':
drivers/ntb//test/ntb_perf.c:375:3: error: implicit declaration of function 'ntb_peer_msg_write'; did you mean 'ntb_peer_spad_write'? [-Werror=implicit-function-declaration]
ntb_peer_msg_write(perf->ntb, peer->pidx, PERF_MSG_LDATA,
^~~~~~~~~~~~~~~~~~
ntb_peer_spad_write
drivers/ntb//test/ntb_perf.c: In function 'perf_msg_cmd_recv':
drivers/ntb//test/ntb_perf.c:408:32: warning: passing argument 2 of 'ntb_msg_read' makes integer from pointer without a cast [-Wint-conversion]
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_CMD);
^~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: expected 'int' but argument is of type 'int *'
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:408:8: error: too few arguments to function 'ntb_msg_read'
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_CMD);
^~~~~~~~~~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: declared here
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:411:32: warning: passing argument 2 of 'ntb_msg_read' makes integer from pointer without a cast [-Wint-conversion]
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_LDATA);
^~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: expected 'int' but argument is of type 'int *'
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:229:25: warning: passing argument 3 of 'ntb_msg_read' makes pointer from integer without a cast [-Wint-conversion]
#define PERF_MSG_LDATA 1
^
drivers/ntb//test/ntb_perf.c:411:38: note: in expansion of macro 'PERF_MSG_LDATA'
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_LDATA);
^~~~~~~~~~~~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: expected 'int *' but argument is of type 'int'
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:411:8: error: too few arguments to function 'ntb_msg_read'
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_LDATA);
^~~~~~~~~~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: declared here
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:414:32: warning: passing argument 2 of 'ntb_msg_read' makes integer from pointer without a cast [-Wint-conversion]
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_HDATA);
^~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: expected 'int' but argument is of type 'int *'
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:230:25: warning: passing argument 3 of 'ntb_msg_read' makes pointer from integer without a cast [-Wint-conversion]
#define PERF_MSG_HDATA 2
^
drivers/ntb//test/ntb_perf.c:414:38: note: in expansion of macro 'PERF_MSG_HDATA'
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_HDATA);
^~~~~~~~~~~~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: expected 'int *' but argument is of type 'int'
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c:414:8: error: too few arguments to function 'ntb_msg_read'
val = ntb_msg_read(perf->ntb, pidx, PERF_MSG_HDATA);
^~~~~~~~~~~~
In file included from drivers/ntb//test/ntb_perf.c:89:0:
include/linux/ntb.h:1473:19: note: declared here
static inline int ntb_msg_read(struct ntb_dev *ntb, int midx, int *pidx,
^~~~~~~~~~~~
drivers/ntb//test/ntb_perf.c: In function 'perf_setup_peer_mw':
>> drivers/ntb//test/ntb_perf.c:1391:35: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'resource_size_t {aka unsigned int}' [-Wformat=]
"Peer %d outbuf reduced to %#llx\n", peer->pidx,
~~~~^
%#x
peer->outbuf_size);
~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +1391 drivers/ntb//test/ntb_perf.c

1370
1371 static int perf_setup_peer_mw(struct perf_peer *peer)
1372 {
1373 struct perf_ctx *perf = peer->perf;
1374 phys_addr_t phys_addr;
1375 int ret;
1376
1377 /* Get outbound MW parameters and map it */
1378 ret = ntb_peer_mw_get_addr(perf->ntb, peer->gidx, &phys_addr,
1379 &peer->outbuf_size);
1380 if (ret)
1381 return ret;
1382
1383 peer->outbuf = devm_ioremap_wc(&perf->ntb->dev, phys_addr,
1384 peer->outbuf_size);
1385 if (!peer->outbuf)
1386 return -ENOMEM;
1387
1388 if (max_mw_size && peer->outbuf_size > max_mw_size) {
1389 peer->outbuf_size = max_mw_size;
1390 dev_warn(&peer->perf->ntb->dev,
> 1391 "Peer %d outbuf reduced to %#llx\n", peer->pidx,
1392 peer->outbuf_size);
1393 }
1394
1395 return 0;
1396 }
1397

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip