Re: [PATCH 1/2] dt-bindings: trivial: add tfa9879 device
From: Peter Rosin
Date: Sun Dec 03 2017 - 15:54:20 EST
On 2017-12-03 12:12, Fabio Estevam wrote:
> Hi Peter,
>
> On Sun, Dec 3, 2017 at 4:59 AM, Peter Rosin <peda@xxxxxxxxxx> wrote:
>
>> Right. However, the patch adding that should have been sent to me, the
>> maintainer of the driver. That is carefully recorded in MAINTAINERS. So,
>> forgive me for assuming that nothing had changed in the driver behind my
>> back.
>>
>> Had that patch been sent my way as it should have been, I would have
>> insisted that maintenance of the bindings had been kept together with
>> the maintenance of the driver.
>
> When I sent this patch ./scripts/get_maintainer.pl did lot list your
> name, so that's why I did not put you on Cc, sorry.
>
> 4.15-rc1 still does not list you, but linux-next does.
That's funny, because I get the below on both 4.14 and 4.15-rc1. And I
expect the same ever since the driver was added some 3 years ago.
$ scripts/get_maintainer.pl your-patch-from[1].diff | grep Peter
Peter Rosin <peda@xxxxxxxxxx> (maintainer:NXP TFA9879 DRIVER)
[1] https://patchwork.ozlabs.org/patch/815930/
By the way, scripts/checkpatch.pl on that patch reports
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> Would you like me to send the following patch so that new binding
> updates go to you?
Naahh, I'll claim it myself, that way I can clean up some nits in the
actual file while at it...
Cheers,
Peter
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9808,6 +9808,7 @@ NXP TFA9879 DRIVER
> M: Peter Rosin <peda@xxxxxxxxxx>
> L: alsa-devel@xxxxxxxxxxxxxxxx (moderated for non-subscribers)
> S: Maintained
> +F: Documentation/devicetree/bindings/sound/tfa9879.txt
> F: sound/soc/codecs/tfa9879*
>