Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

[Kaiwan N Billimoria]

> On Mon, Dec 4, 2017 at 10:25 AM, Tobin C. Harding <me@xxxxxxxx> wrote:
>>
>> > With the 'eval', no warning, it's fine.
>>
>> Why not use hex()?
>
>> >
>> >         foreach my $config_file (@config_files) {
>> > +               $config_file =~ s/\R*//g;
>>
>> Is there some reason you don't use chomp()?
>

Wrt your suggestions:

---
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index 9906dcf8b807..260b52e456f1 100755
--- a/scripts/leaking_addresses.pl
+++ b/scripts/leaking_addresses.pl
@@ -266,7 +266,7 @@ sub is_false_positive
 sub is_false_positive_ix86_32
 {
        my ($match) = @_;
-       state $page_offset = eval get_page_offset(); # only gets called once
+       state $page_offset = hex get_page_offset(); # only gets called once

        if ($match =~ '\b(0x)?(f|F){8}\b') {
                return 1;
@@ -313,7 +313,7 @@ sub get_page_offset
        }

        foreach my $config_file (@config_files) {
-               $config_file =~ s/\R*//g;
+               chomp $config_file;
                $page_offset = parse_kernel_config_file($config_file);
                if ($page_offset ne "") {
                        return $page_offset;


Thanks & Regards,
Kaiwan.