Re: [PATCH v2 2/2] cros_ec: Move cros_ec_dev module to drivers/mfd

[Lee Jones]

On Fri, 01 Dec 2017, Gwendal Grignou wrote:

> Reviewed-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>

Can you please reply inline (where Guenter did is perfect) and snip
the rest please?  Top posting is to be strongly discouraged.

> On Thu, Nov 30, 2017 at 12:50 PM, Guenter Roeck <groeck@xxxxxxxxxx> wrote:
> > On Mon, Nov 20, 2017 at 8:15 AM, Thierry Escande
> > <thierry.escande@xxxxxxxxxxxxx> wrote:
> >> The cros_ec_dev module is responsible for registering the MFD devices
> >> attached to the ChromeOS EC. This patch moves this module to drivers/mfd
> >> so calls to mfd_add_devices() are not done from outside the MFD subtree
> >> anymore.
> >>
> >> Signed-off-by: Thierry Escande <thierry.escande@xxxxxxxxxxxxx>
> >
> > Tested-by: Guenter Roeck <groeck@xxxxxxxxxxxx>
> >
> >> ---
> >>  drivers/mfd/Kconfig                        |  10 +
> >>  drivers/mfd/Makefile                       |   1 +
> >>  drivers/mfd/cros_ec_dev.c                  | 552 ++++++++++++++++++++++++++++
> >>  drivers/mfd/cros_ec_dev.h                  |  52 +++
> >>  drivers/platform/chrome/Kconfig            |  10 -
> >>  drivers/platform/chrome/Makefile           |   1 -
> >>  drivers/platform/chrome/cros_ec_debugfs.c  |   3 -
> >>  drivers/platform/chrome/cros_ec_debugfs.h  |  27 --
> >>  drivers/platform/chrome/cros_ec_dev.c      | 553 -----------------------------
> >>  drivers/platform/chrome/cros_ec_dev.h      |  52 ---
> >>  drivers/platform/chrome/cros_ec_lightbar.c |   2 -
> >>  drivers/platform/chrome/cros_ec_sysfs.c    |   2 -
> >>  include/linux/mfd/cros_ec.h                |   4 +
> >>  13 files changed, 619 insertions(+), 650 deletions(-)
> >>  create mode 100644 drivers/mfd/cros_ec_dev.c
> >>  create mode 100644 drivers/mfd/cros_ec_dev.h
> >>  delete mode 100644 drivers/platform/chrome/cros_ec_debugfs.h
> >>  delete mode 100644 drivers/platform/chrome/cros_ec_dev.c
> >>  delete mode 100644 drivers/platform/chrome/cros_ec_dev.h

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog