Re: [PATCH v2] soc: qcom: smp2p: Access APCS as mailbox client

[Bjorn Andersson]

On Fri 01 Dec 14:25 PST 2017, Rob Herring wrote:

> On Wed, Nov 29, 2017 at 04:00:40PM -0800, Bjorn Andersson wrote:
> > Attempt to acquire the APCS IPC through the mailbox framework and fall
> > back to the old syscon based approach, to allow us to move away from
> > using the syscon.
> > 
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > ---
> > 
> > Changes since v1:
> > - Added dt binding update
> > - Specifies knows_txdone on the mailbox client
> > 
> >  .../devicetree/bindings/soc/qcom/qcom,smp2p.txt    |  8 ++++-
> >  drivers/soc/qcom/Kconfig                           |  1 +
> >  drivers/soc/qcom/smp2p.c                           | 39 ++++++++++++++++++----
> >  3 files changed, 41 insertions(+), 7 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt
> > index af9ca37221ce..a35af2dafdad 100644
> > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt
> > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt
> > @@ -17,9 +17,15 @@ processor ID) and a string identifier.
> >  	Value type: <prop-encoded-array>
> >  	Definition: one entry specifying the smp2p notification interrupt
> >  
> > -- qcom,ipc:
> > +- mboxes:
> >  	Usage: required
> >  	Value type: <prop-encoded-array>
> > +	Definition: reference to the associated doorbell in APCS, as described
> > +		    in mailbox/mailbox.txt
> > +
> > +- qcom,ipc:
> > +	Usage: required, unless mboxes is specified
> 
> Is this deprecated as mboxes is required, so it's never present?
> 

Right, this required property "mboxes" replaces the previously required
property "qcom,ipc". This comes from migrating the description of APCS
as a syscon to a mailbox/doorbell.

Regards,
Bjorn

> > +	Value type: <prop-encoded-array>
> >  	Definition: three entries specifying the outgoing ipc bit used for
> >  		    signaling the remote end of the smp2p edge:
> >  		    - phandle to a syscon node representing the apcs registers