Re: [PATCH v3 02/21] fpga: mgr: add region_id to fpga_image_info

[Alan Tull]

On Wed, Nov 29, 2017 at 12:11 AM, Moritz Fischer <mdf@xxxxxxxxxx> wrote:
> Hi Hao,
>
> On Mon, Nov 27, 2017 at 02:42:09PM +0800, Wu Hao wrote:
>> This patch adds region_id to fpga_image_info data structure, it
>> allows driver to pass region id information to fpga-mgr via
>> fpga_image_info for fpga reconfiguration function.
>>
>> Signed-off-by: Wu Hao <hao.wu@xxxxxxxxx>
> Acked-by: Moritz Fischer <mdf@xxxxxxxxxx>

Acked-by: Alan Tull <atull@xxxxxxxxxx>

>> ----
>> v3: add one line comment for region_id
>> ---
>>  include/linux/fpga/fpga-mgr.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
>> index 1ad4822..6e98b66 100644
>> --- a/include/linux/fpga/fpga-mgr.h
>> +++ b/include/linux/fpga/fpga-mgr.h
>> @@ -88,6 +88,7 @@ enum fpga_mgr_states {
>>   * @sgt: scatter/gather table containing FPGA image
>>   * @buf: contiguous buffer containing FPGA image
>>   * @count: size of buf
>> + * @region_id: id of target region
>>   * @dev: device that owns this
>>   * @overlay: Device Tree overlay
>>   */
>> @@ -100,6 +101,7 @@ struct fpga_image_info {
>>       struct sg_table *sgt;
>>       const char *buf;
>>       size_t count;
>> +     int region_id;
>>       struct device *dev;
>>  #ifdef CONFIG_OF
>>       struct device_node *overlay;
>> --
>> 1.8.3.1
>>
>
> Moritz