Re: [PATCH v2 1/5] fpga: region: don't use drvdata in common fpga code
From: Alan Tull
Date: Mon Dec 04 2017 - 17:04:23 EST
On Mon, Dec 4, 2017 at 3:32 PM, Moritz Fischer <mdf@xxxxxxxxxx> wrote:
> On Wed, Nov 15, 2017 at 02:51:48PM -0600, Alan Tull wrote:
>> Part of patchset that changes the following fpga_*_register
>> functions to not set drvdata:
>> * fpga_region_register.
>> * fpga_mgr_register
>> * fpga_bridge_register
>>
>> The rationale is that setting drvdata is fine for DT based devices
>> that will have one manager, bridge, or region per platform device.
>> However PCIe based devices may have multiple FPGA mgr/bridge/regions
>> under one PCIe device. Without these changes, the PCIe solution has
>> to create an extra device for each child mgr/bridge/region to hold
>> drvdata.
>>
>> Signed-off-by: Alan Tull <atull@xxxxxxxxxx>
>> Reported-by: Jiuyue Ma <majiuyue@xxxxxxxxxx>
> Acked-by: Moritz Fischer <mdf@xxxxxxxxxx>
Thanks!
Alan