Re: [PATCH 4/8] ASoC: uniphier: add support for UniPhier EVEA codec

[Masahiro Yamada]

+CC Greg-KH
+CC Thomas Gleixner

2017-12-05 3:20 GMT+09:00 Mark Brown <broonie@xxxxxxxxxx>:
> On Wed, Nov 22, 2017 at 08:43:17PM +0900, Katsuhiro Suzuki wrote:
>
>> +++ b/sound/soc/uniphier/evea.c
>> @@ -0,0 +1,567 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Socionext UniPhier EVEA ADC/DAC codec driver.
>> + *
>> + * Copyright (c) 2016-2017 Socionext Inc.
>
> Make the entire comment a C++ comment, don't mix and match like this -
> it's ugly.  Otherwise this looks good so I'll apply it, please send a
> followup patch fixing this (and I guess the same thing will apply to
> other files).


Indeed ugly,
but I think this is intentional to make the SPDX line stand out.


Linus suggested this as far as I understood from the following:
https://patchwork.kernel.org/patch/10016201/


If you use C++ comment style for the entire block,
it will not stand out.




-- 
Best Regards
Masahiro Yamada