Re: [PATCH v2 02/22] mmc: renesas_sdhi: remove wrong depends on to enable compile test
From: Masahiro Yamada
Date: Mon Dec 04 2017 - 23:17:41 EST
2017-12-05 0:25 GMT+09:00 Wolfram Sang <wsa@xxxxxxxxxxxxx>:
> On Sat, Nov 25, 2017 at 01:24:37AM +0900, Masahiro Yamada wrote:
>> ARCH_RENESAS is a stronger condition than (ARM || ARM64).
>> If ARCH_RENESAS is enabled, (ARM || ARM64) is met as well.
>>
>> What is worse, the first depends on line prevents COMPILE_TEST from
>> enabling this driver. It should be removed.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>> Acked-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>
> Because COMPILE_TEST now works, buildbot spotted something:
>
> https://www.spinics.net/lists/linux-i2c/msg32556.html
>
> Likely, we should include linux/io.h in the header?
>
Yes. Can you insert a patch before this one?
--
Best Regards
Masahiro Yamada