RE: [PATCH v4 07/12] [media] cxd2880: Add top level of the driver
From: Takiguchi, Yasunari
Date: Tue Dec 05 2017 - 06:47:30 EST
Dear Sean
Hi, Thanks for your review.
We will refer to your comments and consider how to respond for them.
> > + u8 rdata[2];
> > + int ret;
> > +
> > + if ((!tnrdmd) || (!pre_bit_err) || (!pre_bit_count))
> > + return -EINVAL;
> > +
> > + if (tnrdmd->diver_mode == CXD2880_TNRDMD_DIVERMODE_SUB)
> > + return -EINVAL;
>
> divermode: this should say drivermode, correct?
diver_mode is not typo, because cxd2880 has diversity function.
> > +MODULE_DESCRIPTION(
> > +"Sony CXD2880 DVB-T2/T tuner + demodulator drvier");
>
> drvier => driver
Yes. It is typo. We will also re-check other patch files.
Thanks
Takiguchi