Re: [PATCH 3/3] crypto: exynos - Reseed PRNG after generating 2^16 random bytes

[Stephan Mueller]

Am Dienstag, 5. Dezember 2017, 13:35:58 CET schrieb Åukasz Stelmach:

Hi Åukasz,

> Reseed PRNG after reading 65 kB of randomness. Although this may reduce
> performance, in most casese the loss is not noticable.

Please add to the log that you also increase the timer-based reseed to 1 
second?!

Another suggestion: maybe you want to add a comment to the reseed function to 
indicate it is for enhanced backtracking resistance. Otherwise a lot of folks 
would scratch their head why such code exists in the first place. :-)

Other than that:

Reviewed-by: Stephan Mueller <smueller@xxxxxxxxxx>

Ciao
Stephan