RE: [PATCH V2 net-next 0/3] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver

[Salil Mehta]

> -----Original Message-----
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Tuesday, December 05, 2017 4:49 PM
> To: Salil Mehta <salil.mehta@xxxxxxxxxx>
> Cc: Zhuangyuzeng (Yisen) <yisen.zhuang@xxxxxxxxxx>; lipeng (Y)
> <lipeng321@xxxxxxxxxx>; mehta.salil.lnk@xxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> rdma@xxxxxxxxxxxxxxx; Linuxarm <linuxarm@xxxxxxxxxx>
> Subject: Re: [PATCH V2 net-next 0/3] net: hns3: Refactors "reset"
> handling code in HCLGE layer of HNS3 driver
> 
> From: Salil Mehta <salil.mehta@xxxxxxxxxx>
> Date: Mon, 4 Dec 2017 01:29:52 +0000
> 
> > This patch refactors the code of the reset feature in HCLGE layer
> > of HNS3 PF driver. Prime motivation to do this change is:
> > 1. To reduce the time for which common miscellaneous Vector 0
> >    interrupt is disabled because of the reset. Simplification
> >    of the common miscellaneous interrupt handler routine(for
> >    Vector 0) used to handle reset and other sources of Vector
> >    0 interrupt.
> > 2. Separate the task for handling the reset
> > 3. Simplification of reset request submission and pending reset
> >    logic.
> >
> >
> > To achieve above below few things have been done:
> > 1. Interrupt is disabled while common miscellaneous interrupt
> >    handler is entered and re-enabled before it is exit. This
> >    reduces the interrupt handling latency as compared to older
> >    interrupt handling scheme where interrupt was being disabled
> >    in interrupt handler context and re-enabled in task context
> >    some time later. Made Miscellaneous interrupt handler more
> >    generic to handle all sources including reset interrupt source.
> > 2. New reset service task has been introduced to service the
> >    reset handling.
> > 3. Introduces new reset service task for honoring software reset
> >    requests like from network stack related to timeout and serving
> >    the pending reset request(to reset the driver and associated
> >    clients).
> >
> >
> > Change Log:
> > Patch V2: Addressed comment by Andrew Lunn
> >    Link: https://lkml.org/lkml/2017/12/1/366
> > Patch V1: Initial Submit
> 
> Series applied, thank you.

Thanks Dave.