Re: efi/esrt: use memunmap rather kfree to free the remapping

[Ard Biesheuvel]

On 29 October 2017 at 14:51, Pan Bian <bianpan2016@xxxxxxx> wrote:
> The remapping result of memremap should be freed with memunmap, not
> kfree.
>
> Signed-off-by: Pan Bian <bianpan2016@xxxxxxx>
> ---
>  drivers/firmware/efi/esrt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index bd7ed3c..3ef7001 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -431,7 +431,7 @@ static int __init esrt_sysfs_init(void)
>  err_remove_esrt:
>         kobject_put(esrt_kobj);
>  err:
> -       kfree(esrt);
> +       memunmap(esrt);
>         esrt = NULL;
>         return error;
>  }
> --
> 1.9.1
>

Queued in efi/urgent. Thanks.