Re: [PATCH v2] pata_pdc2027x: Fix coding sytle errors
From: Tejun Heo
Date: Tue Dec 05 2017 - 14:50:17 EST
On Tue, Dec 05, 2017 at 11:56:38PM +0530, Arvind Yadav wrote:
> Fix these checkpatch.pl errors:
> Fix checkpatch.pl error:
> ERROR: space prohibited before open square bracket '['.
>
> ERROR: space prohibited after that '~' (ctx:WxW)
> + mask &= ~ (1 << (6 + ATA_SHIFT_UDMA));
>
> ERROR: spaces required around that '?' (ctx:VxW)
> + long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
>
> ERROR: that open brace { should be on the previous line
> + const struct ata_port_info *ppi[] =
> + { &pdc2027x_port_info[board_idx], NULL };
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
Patch doesn't apply to libata/for-4.16. Also, please keep Bart's
Acked-by when posting updated versions.
Thanks.
--
tejun