Re: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop using the flash

From: Cyrille Pitchen
Date: Tue Dec 05 2017 - 15:41:04 EST


Hi Hou,

Le 05/12/2017 Ã 06:33, Zhiqiang Hou a Ãcrit :
> From: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx>
>
> To be compatible with legacy device, reset the addressing mode
> to the default mode. Such as Freescale eSPI boot, it copies the
> images from SPI flash without firing a reset signal previously,
> so the reboot command will fail without reseting the addressing
> mode of SPI flash.
>

You should put this in one of the commit messages so it explains which
issue is fixed by your patches.

Otherwise, your series looks good to me :)

Best regards,

Cyrille

> Hou Zhiqiang (2):
> mtd: spi-nor: add an API to restore the status of SPI flash chip
> mtd: m25p80: restore the status of SPI flash when stop using it
>
> Documentation/mtd/spi-nor.txt | 3 +++
> drivers/mtd/devices/m25p80.c | 9 +++++++++
> drivers/mtd/spi-nor/spi-nor.c | 10 ++++++++++
> include/linux/mtd/spi-nor.h | 6 ++++++
> 4 files changed, 28 insertions(+)
>