Re: [PATCH v8 10/13] dt-bindings: Add qcom slimbus controller bindings

[Srinivas Kandagatla]

On 04/12/17 21:28, Rob Herring wrote:
> On Thu, Nov 30, 2017 at 05:41:57PM +0000, srinivas.kandagatla@xxxxxxxxxx wrote:
> > From: Sagar Dharia <sdharia@xxxxxxxxxxxxxx>
> >
> > This patch add device tree bindings for Qualcomm slimbus controller.
> >
> > Signed-off-by: Sagar Dharia <sdharia@xxxxxxxxxxxxxx>
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/slimbus/slim-qcom-ctrl.txt | 39 ++++++++++++++++++++++
> >   1 file changed, 39 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/slimbus/slim-qcom-ctrl.txt
> >
> > + - clocks : Interface and core clocks used by this SLIMbus controller
> > + - clock-names : Required clock-name entries are:
> > +	"iface_clk" : Interface clock for this controller
> > +	"core_clk" : Interrupt for controller core's BAM
>
> Doesn't match the example. You should drop the '_clk'. With that,

Thanks for the Reviewed-by tag, I will fix the above in next version.

> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>