RE: [PATCH v6 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma
From: Appana Durga Kedareswara Rao
Date: Tue Dec 05 2017 - 23:11:43 EST
Hi Mike Looijmans,
Thanks for the review...
Sorry for the long delay in the reply...
Please find comments inline...
<Snip>
>On 14-01-17 06:35, Kedareswara rao Appana wrote:
>>ÂÂWhen VDMA is configured for more than one frame in the h/w.
>>ÂÂFor example h/w is configured for n number of frames, user
>>ÂÂSubmits n number of frames and triggered the DMA using issue_pending API.
>>
>>ÂÂIn the current driver flow we are submitting one frame at a time,
>>ÂÂBut we should submit all the n number of frames at one time
>>ÂÂAs the h/w is configured for n number of frames.
>
>The hardware can always handle a single frame submission, by using the "park"
>bit. This would make a good "cyclic" implementation too (using vdma as
>framebuffer).
>
>It could also handle all cases for "k" frames where n%k==0 (n is a multiple of
>k) by simply replicating the frame pointers.
Agree with your comments will fix it in the next version.
Somehow didn't get enough time to send next version of the patch series.
Will modify the driver as per your comments and will post next version of the patch series at the earliest...
Regards,
Kedar.