Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

[Dan Carpenter]

On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote:
> > diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h
> > index babe597e2ec6..5247e9269de9 100644
> > --- a/drivers/staging/pi433/rf69_enum.h
> > +++ b/drivers/staging/pi433/rf69_enum.h
> > @@ -18,9 +18,9 @@
> >   #ifndef RF69_ENUM_H
> >   #define RF69_ENUM_H
> > -enum optionOnOff {
> > -	optionOff,
> > -	optionOn
> > +enum option_on_off {
> > +	OPTION_OFF,
> > +	OPTION_ON
> >   };
> >   enum mode {
> > 
> 
> Hi Simon,
> 
> nice work.
> 
> Thank you very much for all the style fixes :-)
> 


Wow...  This was the one patch I thought was going to sink this
patchset...  Isn't enum optionOnOff part of the userspace headers?

I thought we weren't allowed to change that.

regards,
dan carpenter