[PATCH] spi: sun4i: disable clocks in the remove function
From: Takuo Koguchi
Date: Wed Dec 06 2017 - 09:45:50 EST
mclk and hclk need to be disabled explicitly since pm_runtime_disable does
not disable the clocks.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Takuo Koguchi <takuo.koguchi.sw@xxxxxxxxxxx>
---
drivers/spi/spi-sun4i.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c
index c5cd635..9011c09 100644
--- a/drivers/spi/spi-sun4i.c
+++ b/drivers/spi/spi-sun4i.c
@@ -525,6 +525,11 @@ static int sun4i_spi_probe(struct platform_device *pdev)
static int sun4i_spi_remove(struct platform_device *pdev)
{
+ struct spi_master *master = dev_get_drvdata(&pdev->dev);
+ struct sun4i_spi *sspi = spi_master_get_devdata(master);
+
+ clk_disable_unprepare(sspi->mclk);
+ clk_disable_unprepare(sspi->hclk);
pm_runtime_disable(&pdev->dev);
return 0;
--
2.7.4