Re: [PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro

From: Greg Kroah-Hartman
Date: Wed Dec 06 2017 - 10:19:03 EST


On Sun, Dec 03, 2017 at 01:09:49AM +0100, Nguyen Phan Quang Minh wrote:
> The macro calls its argument -a function- twice, makes the calling
> function return prematurely -skipping resource cleanup code- and hurts
> understandability.
>
> Signed-off-by: Nguyen Phan Quang Minh <minhnpq16@xxxxxxxxx>
> ---
> Base on Dan's feedback, I checked and the macro return indeed skips over
> some cleanup code, hence remove it.
> The code is not pretty, any hints on how to do it better is greatly
> appreciated.

Please redo this based on Dan's comments.

thanks,

greg k-h