Re: [PATCH v3 34/36] ALSA/dummy: Replace tasklet with softirq hrtimer

From: Takashi Iwai
Date: Wed Dec 06 2017 - 11:27:40 EST


On Wed, 29 Nov 2017 16:30:59 +0100,
Anna-Maria Gleixner wrote:
>
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> The tasklet is used to defer the execution of snd_pcm_period_elapsed() to
> the softirq context. Using the HRTIMER_MODE_SOFT mode invokes the timer
> callback in softirq context as well which renders the tasklet useless.
>
> [o-takashi: avoid stall due to a call of hrtimer_cancel() on a callback
> of hrtimer]
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
> Cc: alsa-devel@xxxxxxxxxxxxxxxx
> Cc: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxxx>
> Cc: Jaroslav Kysela <perex@xxxxxxxx>
> Link: http://lkml.kernel.org/r/20170905161820.jtysvxtfleunbbmf@xxxxxxxxxxxxx

Feel free to take my ack:
Reviewed-by: Takashi Iwai <tiwai@xxxxxxx>


thanks,

Takashi