Re: [PATCH] x86/mm/kaiser: avoid 32-bit/PAE build warning

From: Ingo Molnar
Date: Wed Dec 06 2017 - 16:03:08 EST



* Arnd Bergmann <arnd@xxxxxxxx> wrote:

> On Wed, Dec 6, 2017 at 6:16 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> >
> > * Arnd Bergmann <arnd@xxxxxxxx> wrote:
> >
> >> On Wed, Dec 6, 2017 at 4:08 PM, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> wrote:
> >> > On 12/06/2017 07:03 AM, Arnd Bergmann wrote:
> >> >> On Wed, Dec 6, 2017 at 3:15 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> >> >>
> >> >> Maybe it's better to just to the last one-line change in include/linux/kaiser.h.
> >> >
> >> > Hi Arnd,
> >> >
> >> > Are you hitting this in -next?
> >> >
> >> > The newest version of this code has a single kpti_init() function that
> >> > shouldn't have any of these problems.
> >>
> >> Yes, this is next-20171206, apparently it came in through tip/auto-latest,
> >> which still has the same version.
> >
> > I'll update the -next version probably later today.
>
> Thanks!
>
> I just ran into another build error with KAISER:
>
> arch/x86/mm/kaiser.c:173:28: error: '__GFP_NOTRACK' undeclared (first
> use in this function); did you mean '__GFP_NOFAIL'?
>
> When you do the update, can you check that it doesn't reference __GFP_NOTRACK?
> Apparently the flag got removed in 4.15-rc1.

Yeah, saw it too and fixed this one as well.

Thanks,

Ingo