Re: [PATCH v3 0/2] of: overlay: Fix of_overlay_apply() error path

From: Rob Herring
Date: Wed Dec 06 2017 - 17:07:44 EST


On Tue, Dec 05, 2017 at 09:40:33PM -0500, Frank Rowand wrote:
> On 12/05/17 10:27, Geert Uytterhoeven wrote:
> > Hi Pantelis, Rob, Frank,
> >
> > Here's a replacement for commit bd80e2555c5c9d45 ("of: overlay: Fix
> > cleanup order in of_overlay_apply()"), which was applied by Rob, and
> > dropped later.
> >
> > The first patch fixes the memory leak reported by Colin.
> > The second patch is a replacement for the bad dropped commit, and
> > depends on the first patch for proper cleanup.
> >
> > All OF unittests pass.
> >
> > Thanks!
> >
> > Geert Uytterhoeven (2):
> > of: overlay: Fix memory leak in of_overlay_apply() error path
> > of: overlay: Fix (un)locking in of_overlay_apply()
> >
> > drivers/of/overlay.c | 31 +++++++++++++------------------
> > 1 file changed, 13 insertions(+), 18 deletions(-)
> >
>
> Thank you, the code is much improved by these patches.
>
> Reviewed-by: Frank Rowand <frank.rowand@xxxxxxxx>

Applied.

Rob