Re: [PATCH V11 4/5] vsprintf: add printk specifier %px
From: Tobin C. Harding
Date: Thu Dec 07 2017 - 00:12:17 EST
On Wed, Dec 06, 2017 at 09:32:14AM +0100, Geert Uytterhoeven wrote:
> Hi Linus,
>
> On Wed, Dec 6, 2017 at 2:59 AM, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Tue, Dec 5, 2017 at 5:36 PM, Sergey Senozhatsky
> > <sergey.senozhatsky.work@xxxxxxxxx> wrote:
> >> I see some %p-s being used in _supposedly_ important output,
> >> like arch/x86/mm/fault.c
> >>
> >> show_fault_oops(struct pt_regs *regs, unsigned long error_code,
> >> unsigned long address)
> >> ...
> >> printk(KERN_CONT " at %p\n", (void *) address);
> >> printk(KERN_ALERT "IP: %pS\n", (void *)regs->ip);
> >
> > So %pS isn't %p, and shows the symbolic name.
>
> If the symbolic name is available.
> Else it prints the non-hashed pointer value (FTR).
I'm trying to fix this :)
[RFC 0/3] kallsyms: don't leak address when printing symbol
thanks,
Tobin.