RE: [PATCH v2] arm64: dts: ls1088a: Add USB support

[Yinbo Zhu]

Hi shawn guo,

If my patch has no other issue, 
Can you help me push it to upstream.

Thanks.
BRs.

-----Original Message-----
From: Yinbo Zhu 
Sent: Wednesday, November 22, 2017 9:32 AM
To: 'Shawn Guo' <shawnguo@xxxxxxxxxx>
Cc: 'Rob Herring' <robh+dt@xxxxxxxxxx>; 'Mark Rutland' <mark.rutland@xxxxxxx>; 'Catalin Marinas )' <catalin.marinas@xxxxxxx>; 'Will Deacon )' <will.deacon@xxxxxxx>; Harninder Rai <harninder.rai@xxxxxxx>; 'Raghav Dogra' <raghav.dogra@xxxxxxx>; Ashish Kumar <ashish.kumar@xxxxxxx>; Andy Tang <andy.tang@xxxxxxx>; 'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS' <devicetree@xxxxxxxxxxxxxxx>; 'linux-arm-kernel@xxxxxxxxxxxxxxxxxxx' <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; 'open list' <linux-kernel@xxxxxxxxxxxxxxx>
Subject: RE: [PATCH v2] arm64: dts: ls1088a: Add USB support

Hi

-----Original Message-----
From: Yinbo Zhu 
Sent: Tuesday, November 14, 2017 4:00 PM
To: 'Shawn Guo' <shawnguo@xxxxxxxxxx>
Cc: 'Rob Herring' <robh+dt@xxxxxxxxxx>; 'Mark Rutland' <mark.rutland@xxxxxxx>; 'Catalin Marinas )' <catalin.marinas@xxxxxxx>; 'Will Deacon )' <will.deacon@xxxxxxx>; Harninder Rai <harninder.rai@xxxxxxx>; 'Raghav Dogra' <raghav.dogra@xxxxxxx>; Ashish Kumar <ashish.kumar@xxxxxxx>; Andy Tang <andy.tang@xxxxxxx>; 'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS' <devicetree@xxxxxxxxxxxxxxx>; 'linux-arm-kernel@xxxxxxxxxxxxxxxxxxx' <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; 'open list' <linux-kernel@xxxxxxxxxxxxxxx>
Subject: RE: [PATCH v2] arm64: dts: ls1088a: Add USB support



-----Original Message-----
From: Yinbo Zhu 
Sent: Tuesday, October 24, 2017 5:15 PM
To: Shawn Guo <shawnguo@xxxxxxxxxx>
Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; Catalin Marinas ) <catalin.marinas@xxxxxxx>; Will Deacon ) <will.deacon@xxxxxxx>; Harninder Rai <harninder.rai@xxxxxxx>; Raghav Dogra <raghav.dogra@xxxxxxx>; Ashish Kumar <ashish.kumar@xxxxxxx>; Andy Tang <andy.tang@xxxxxxx>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; open list <linux-kernel@xxxxxxxxxxxxxxx>
Subject: RE: [PATCH v2] arm64: dts: ls1088a: Add USB support


-----Original Message-----
From: Shawn Guo [mailto:shawnguo@xxxxxxxxxx] 
Sent: Friday, September 22, 2017 2:55 PM
To: Yinbo Zhu <yinbo.zhu@xxxxxxx>
Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; Catalin Marinas ) <catalin.marinas@xxxxxxx>; Will Deacon ) <will.deacon@xxxxxxx>; Harninder Rai <harninder.rai@xxxxxxx>; Raghav Dogra <raghav.dogra@xxxxxxx>; Ashish Kumar <ashish.kumar@xxxxxxx>; Andy Tang <andy.tang@xxxxxxx>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; open list <linux-kernel@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2] arm64: dts: ls1088a: Add USB support

On Wed, Sep 13, 2017 at 05:10:09PM +0800, yinbo.zhu@xxxxxxx wrote:
> From: "yinbo.zhu" <yinbo.zhu@xxxxxxx>
> 
> Fix the issue that usb is not detected on ls1088ardb

>It's not really about fixing issue but adding support.

The patch had been tested on upstream 4.14 code, it can fix the issue. 
> 
> Signed-off-by: yinbo.zhu <yinbo.zhu@xxxxxxx>
> Signed-off-by: Ran Wang <ran.wang_1@xxxxxxx>
> ---

>You should better have a version history here to tell what's changed between version.

>I will add a version history on next v3 patch
Hi,

I had modified the code as v4 version, 
https://patchwork.kernel.org/patch/10027393/
please check.

Thanks,
BRs
>  arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts |  8 ++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi    | 20 ++++++++++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts 
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index 213abb72de93..6c3c3bc4b681 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -118,6 +118,14 @@
>  	status = "okay";
>  };
>  
> +&usb0 {
> +	status = "okay";
> +};
> +
> +&usb1 {
> +	status = "okay";
> +};
> +
>  &esdhc {

>Please sort these labeled nodes alphabetically.

>Shawn

>  	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi 
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index c144d06a6e33..c23fede8cf5d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -359,6 +359,26 @@
>  			status = "disabled";
>  		};
>  
> +		usb0: usb3@3100000 {
> +			compatible = "snps,dwc3";
> +			reg = <0x0 0x3100000 0x0 0x10000>;
> +			interrupts = <0 80 IRQ_TYPE_LEVEL_HIGH>;
> +			dr_mode = "host";
> +			snps,quirk-frame-length-adjustment = <0x20>;
> +			snps,dis_rxdet_inp3_quirk;
> +			status = "disabled";
> +		};
> +
> +		usb1: usb3@3110000 {
> +			compatible = "snps,dwc3";
> +			reg = <0x0 0x3110000 0x0 0x10000>;
> +			interrupts = <0 81 IRQ_TYPE_LEVEL_HIGH>;
> +			dr_mode = "host";
> +			snps,quirk-frame-length-adjustment = <0x20>;
> +			snps,dis_rxdet_inp3_quirk;
> +			status = "disabled";
> +		};
> +
>  		sata: sata@3200000 {
>  			compatible = "fsl,ls1088a-ahci";
>  			reg = <0x0 0x3200000 0x0 0x10000>,
> --
> 2.14.1
>