Re: [patch 31/60] x86/mm/kpti: Add mapping helper functions

[Borislav Petkov]

On Tue, Dec 05, 2017 at 05:01:34PM +0100, Borislav Petkov wrote:
> > +/*
> > + * Take a PGD location (pgdp) and a pgd value that needs to be set there.
> > + * Populates the user and returns the resulting PGD that must be set in
> > + * the kernel copy of the page tables.
> > + */
> > +static inline pgd_t kpti_set_user_pgd(pgd_t *pgdp, pgd_t pgd)
> > +{
> 
> Btw, do we want to inline a relatively big function like that? I see at
> least 20-ish callsites of set_pgd() only.

Yap, looking at Hugh's version, he has moved it to kaiser.c. I guess in
our case, that should be arch/x86/mm/kpti.c respectively.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)
--