Re: [PATCH][next] pinctrl: intel: ensure error return ret is initialized

[Linus Walleij]

On Mon, Dec 4, 2017 at 6:08 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> In the (unlikely) event that community->ngpps is zero, or if every
> gpp->gpio_base is less than zero, then an ininitialized value in
> ret is returned by function intel_gpio_add_pin_ranges. Fix this by
> ensuring ret is initialized to zero.  It's a moot point, but I think
> it is worthwhile ensuring this corner case is fixed.
>
> Detected by CoverityScan, CID#1462415 ("Uninitialized scalar variable")
>
> Fixes: a60eac3239f0 ("pinctrl: intel: Allow custom GPIO base for pad groups")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Patch applied with Mika's ACK.

Thanks for running these Coverity scans.

Yours,
Linus Walleij