Re: [PATCH v1 1/2] ASoC: rsnd: ssi: fix race condition in rsnd_ssi_pointer_update

From: Kuninori Morimoto
Date: Thu Dec 07 2017 - 04:45:58 EST



Hi Jiada

Thank you for your patch

> Currently there is race condition between set of byte_pos and wrap
> it around when new buffer starts. If .pointer is called in-between
> it will result in inconsistent pointer position be returned
> from .pointer callback.
>
> This patch increments buffer pointer atomically to avoid this issue.
>
> Signed-off-by: Jiada Wang <jiada_wang@xxxxxxxxxx>
> Reviewed-by: Takashi Sakamoto <takashi.sakamoto@xxxxxxxxxxxxxxxx>
> ---

You using playback with PIO mode ?
Because this function is no longer used on DMA mode

Best regards
---
Kuninori Morimoto