Re: rsi: fix memory leak on buf and usb_reg_buf

From: Kalle Valo
Date: Thu Dec 07 2017 - 08:26:12 EST


Colin Ian King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> In the cases where len is too long, the error return path fails to
> kfree allocated buffers buf and usb_reg_buf. The simplest fix is to
> perform the sanity check on len before the allocations to avoid having
> to do the kfree'ing in the first place.
>
> Detected by CoverityScan, CID#1452258,1452259 ("Resource Leak")
>
> Fixes: 59f73e2ae185 ("rsi: check length before USB read/write register")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Patch applied to wireless-drivers-next.git, thanks.

c4ee30a280b1 wlcore, wl1251: fix spelling: "Couldnt" -> "Couldn't" and remove error on -ENOMEM

--
https://patchwork.kernel.org/patch/10061619/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches