Re: [PATCH v3] scripts/package: snap-pkg target
From: Masahiro Yamada
Date: Thu Dec 07 2017 - 10:32:25 EST
2017-12-07 3:14 GMT+09:00 Paolo Pisati <paolo.pisati@xxxxxxxxxxxxx>:
> On Wed, Dec 6, 2017 at 11:36 AM, Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>> Just one question to Paolo:
>>
>> If some change like firmware removal happens in the future,
>> patching for snapcraft is necessary?
>> (i.e. users are required to upgrade snapcraft from --edge ?)
>>
>> I guess the answer is yes, because "plugin: kernel" needs to know
>> the kernel-build system internal.
>
> Well, in this case, i had to fix the 'kernel-with-firmware' option to
> skip the 'firmware_install' step since
> we took it by default - let's say that in the future the
> 'modules_install' target is removed or change name,
> then i'll have to patch snapcraft.
>
> Wrt updating from -edge, i told you to take it from there because snap
> packages land there more often and more quickly
> compared to the canonicaldeb archive, so from a developer perspective
> it's easier&quicker to iterate over it, but sooner
> or later (e.g. once snapcraft 2.36.1 reaches the snap -stable
> channel), it will be copied to the deb archive too -
> IOW, you would get using apt-get only too.
> --
I will pick up this for v4.16-rc1.
It sounds like this target is a bit fragile, but let's see.
I hope a breakage will not happen...
--
Best Regards
Masahiro Yamada