Re: [PATCH] dt: bindings: as3645a: Fix the example node

From: Rob Herring
Date: Thu Dec 07 2017 - 10:42:56 EST


On Wed, Dec 6, 2017 at 4:32 PM, Dan Murphy <dmurphy@xxxxxx> wrote:
> Rob
>
> On 12/06/2017 03:52 PM, Rob Herring wrote:
>> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
>>> Fix the address-cells and size-cells example node
>>> to reflect to the correct representation.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
>>> ---
>>> Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>>> index fdc40e354a64..8a49ccfec29b 100644
>>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>>> @@ -59,8 +59,8 @@ Example
>>> =======
>>>
>>> as3645a@30 {
>>> - #address-cells: 1
>>> - #size-cells: 0
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> reg = <0x30>;
>>> compatible = "ams,as3645a";
>>
>> Convention is also we put compatible first.
>>
>
> OK I will move that too for v2.
>
> Can that be in the same patch or do you want a separate patch?

Same patch is fine.

Rob