Re: [PATCH v8 2/2] ARM: dts: TS-4600: add basic device tree

From: Sebastien Bourdelin
Date: Thu Dec 07 2017 - 12:06:18 EST


Hi Fabio

On 11/26/2017 02:39 PM, Fabio Estevam wrote:
> Hi Sebastien,
>
> On Thu, Nov 23, 2017 at 7:04 PM, Sebastien Bourdelin
> <sebastien.bourdelin@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>> + reg_vddio_sd0: regulator-vddio-sd0 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "vddio-sd0";
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> + gpio = <&gpio3 28 GPIO_ACTIVE_HIGH>;
>
> It seems this should be GPIO_ACTIVE_LOW instead, as you don't pass
> 'enable-active-high' here.
>

Yes! you are right, thanks for the catch!

Regards,
Sebastien.