Re: [PATCH v2 2/5] perf-probe: Cut off the version suffix from event name

[Arnaldo Carvalho de Melo]

Em Thu, Dec 07, 2017 at 11:24:47AM -0600, Paul Clarke escreveu:
> On 12/07/2017 10:56 AM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Dec 07, 2017 at 04:20:28PM +0900, Masami Hiramatsu escreveu:
> > See also Paul Clarke's question and suggestion, which I agree, i.e.
> > instead of chopping off the version, just replace the chars with valid
> > ones or better, do what Paul suggests, be more flexible in interpreting
> > @, i.e. if it is a number and/or fails to point to any file, interpret
> > it as versioning.
 
> It's a nit, and subjective, but I'd favor checking for versioning
> first, then file.  The namespaces are very unlikely to intersect, but
> I could foresee symbols like "sym@xxxxxxx" and "sym@xxxxxxx" more
> likely than a symbol in a file "GLIBC_2.2.5".
 
> Perhaps straying toward bikeshedding...

Nah, those are valid concerns, and I share them.

- Arnaldo