Re: [PATCH] mm/slab: Do not hash pointers when debugging slab

From: Kees Cook
Date: Thu Dec 07 2017 - 13:43:17 EST


On Thu, Dec 7, 2017 at 3:13 AM, Christopher Lameter <cl@xxxxxxxxx> wrote:
> On Thu, 7 Dec 2017, Geert Uytterhoeven wrote:
>
>> If CONFIG_DEBUG_SLAB/CONFIG_DEBUG_SLAB_LEAK are enabled, the slab code
>> prints extra debug information when e.g. corruption is detected.
>> This includes pointers, which are not very useful when hashed.
>>
>> Fix this by using %px to print unhashed pointers instead.
>
> Acked-by: Christoph Lameter <cl@xxxxxxxxx>
>
> These SLAB config options are only used for testing so this is ok.

Most systems use SLUB so I can't say how common CONFIG_DEBUG_SLAB is.
(Though, FWIW with SLUB, CONFIG_SLUB_DEBUG is very common.)

-Kees

--
Kees Cook
Pixel Security