Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

[Yang Shi]

On 12/7/17 11:20 AM, Jon Maloy wrote:
> > -----Original Message-----
> > From: netdev-owner@xxxxxxxxxxxxxxx [mailto:netdev-
> > owner@xxxxxxxxxxxxxxx] On Behalf Of Yang Shi
> > Sent: Thursday, December 07, 2017 14:16
> > To: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: linux-mm@xxxxxxxxx; linux-fsdevel@xxxxxxxxxxxxxxx; linux-
> > crypto@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Jon Maloy
> > <jon.maloy@xxxxxxxxxxxx>; Ying Xue <ying.xue@xxxxxxxxxxxxx>; David S.
> > Miller <davem@xxxxxxxxxxxxx>
> > Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h
> >
> > Hi folks,
> >
> > Any comment on this one?
>
> If it compiles it is ok with me. Don't know why it was put there in the first place.

Yes, it does compile.

Yang

> ///jon
>
> > Thanks,
> > Yang
> >
> >
> > On 11/17/17 3:02 PM, Yang Shi wrote:
> > > Preempt counter APIs have been split out, currently, hardirq.h just
> > > includes irq_enter/exit APIs which are not used by TIPC at all.
> > >
> > > So, remove the unused hardirq.h.
> > >
> > > Signed-off-by: Yang Shi <yang.s@xxxxxxxxxxxxxxx>
> > > Cc: Jon Maloy <jon.maloy@xxxxxxxxxxxx>
> > > Cc: Ying Xue <ying.xue@xxxxxxxxxxxxx>
> > > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > > ---
> > >    net/tipc/core.h | 1 -
> > >    1 file changed, 1 deletion(-)
> > >
> > > diff --git a/net/tipc/core.h b/net/tipc/core.h index 5cc5398..099e072
> > > 100644
> > > --- a/net/tipc/core.h
> > > +++ b/net/tipc/core.h
> > > @@ -49,7 +49,6 @@
> > >    #include <linux/uaccess.h>
> > >    #include <linux/interrupt.h>
> > >    #include <linux/atomic.h>
> > > -#include <asm/hardirq.h>
> > >    #include <linux/netdevice.h>
> > >    #include <linux/in.h>
> > >    #include <linux/list.h>