Re: [PATCH] checkpatch: add check for tag Co-Developed-by
From: Tobin C. Harding
Date: Thu Dec 07 2017 - 15:56:26 EST
On Thu, Dec 07, 2017 at 08:26:58AM -0800, Joe Perches wrote:
> On Thu, 2017-12-07 at 11:59 +1100, Tobin C. Harding wrote:
> > Recently signature tag Co-Developed-by was added to the
> > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know
> > about it yet. All prior tags used all lowercase characters except for first
> > character. Checks for this format had to be re-worked to allow for the
> > new tag.
> >
> > Add checkpatch checks for Co-Developed-by tag.
>
> This patch is not extensible.
>
> If this is to be done at all, the Co-Developed-by:
> should not be a special case because a new and
> different one might be added in the future.
I agree, fixing individual corner cases is bad style.
> Better to verify that a case insensitive match exists
> in $signature_tags and then complain if the match is
> not exact.
I'll have a go at this.
thanks,
Tobin.